The latest updates on your projects. Learn more about Vercel for Git ↗︎

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e3396d5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 from NxCloud.

Hello! Thanks for the PR! Do you want to check your errors and fix them? Then I can approve! Have you tested it, does it work properly in all scenarios?

I think format check failed (maybe??). Can you try also nx format?

@nodegin thanks! Did you also run nx format? Can you force-push again, in any case, because CI is stuck?

@mandarini Sorry I updated again to format the code.

@nodegin I reverted your PR because it was causing issues with the source maps. Let me know if you can look into it more, since I guess reverting your PR brings back the devserver issue you had observed.

in version 15.4.4 fileReplacements are not working, i downgraded nx to 15.4.2 and now working

Are you referring to the build fileReplacements, or the devServer fileReplacements? @KayhanB

build is working but devServer is not @mandarini

Linking this here

Will take a look at that some time next week.

@KayhanB @nodegin I'll see how I can fix this so that both build and dev-server work. However, we do suggest this, using import.meta.env.VITE_*, see these docs

Please let me know if there's a reason why you prefer the fileReplacements solution over this.

@mandarini I think for some case we might want to replace some files (e.g. some code logic to execute?) in different environments instead of just configurations

I see. I am working on it!

@nodegin @KayhanB @pgsteven

Hey, people!

So, we decided that this is not in our immediate plans at the moment, after all.

That being said, if any one of you can spend some time putting together a pull request to make this work, I'll be more than happy to test it out, make sure it works, and merge it.

At the same time, if one wants this functionality for Nx, what they can do, is write their own plugin in their workspace, and just add it in the plugins array of their vite.config.js file. I mean, without the plugin needing to be an actual part of Nx. Here's the Plugins API for Vite.

As an alternative, please consider using import.meta.env.VITE_* for variable values, or resolve-alias. I know these do not cover the actual file replacing functionality that you all need for dev server, but they could offer an alternative.

Just as a reminder, fileReplacement does work for the prod builder!

hi @mandarini
vite's import.meta.env feature solves my problem perfectly, I didn't know about this feature before you suggested it. I implemented this solution and got a much cleaner result than fileReplacement. for now i don't have a situation where i need to use fileReplacement. If there is, I will inform you.
thank you for attention

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.